Add the Subscription field to subscription items #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@majelbstoat Thanks a lot for doing the PR yourself! r? @brandur-stripe |
Haha, I checked exactly the same thing. Thanks! |
|
Released as 42.2.0. |
|
Yah, I noticed that, which made me a sad panda. But I can deal with it ;) That turnaround is impressive. Thanks so much! (This work sponsored by Range ❤️) |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Stop splitting order lines * Missing subscription item types * Simplifying contract item struct * Cleanup end dates on subscription phases * Some additional missing types * More missing stripe types * Allow more attributes on mock sf objects * Contract item tests * Functional metadata key * Adding auto-archive helper * Refactor termination aggregation * Helpers to remove terminated lines and add auto_archive metadata * Auto-archive prices, use pricing helpers * Add auto archive metadata to order line prices * Moving termination logic out of the contract struct * Split order tests into multiple files * Multi-amendment termination test * Misc test fixes, mostly due to typing * Updating plan notes * Contract item test fix * Establish origin line item mapping first * Fix duplicated price test * Test fixes * Expand phases as well * Using new test helper * More docs todo * Fixing make_translator test helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per documentation, adds the subscription field to the SubscriptionItem object.
Fixes #665