Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error in issuing_card.go #661

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Conversation

jack-stripe
Copy link
Contributor

eta is a timestamp, like created.

@brandur-stripe
Copy link
Contributor

Oops, yep, that looks more right. Thanks Jack!

@brandur-stripe brandur-stripe merged commit 2aba224 into master Aug 17, 2018
brandur-stripe pushed a commit that referenced this pull request Aug 17, 2018
Convention throughout Go and this library is to upcase field names that
are acronyms. Here we do that for "ETA". We are changing its type anyway
in #661, so it's a good time to make this change.
@brandur-stripe
Copy link
Contributor

Released as 41.0.0.

@brandur-stripe brandur-stripe deleted the jack-fix-issuing-card-eta branch August 17, 2018 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants