Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove editable bitcoin receiver actions #659

Merged

Conversation

tomer-stripe
Copy link
Contributor

@tomer-stripe tomer-stripe commented Aug 16, 2018

Removes the ability to use New and Update for bitcoin receivers. Tests pass!

» go test ./...
ok  	github.com/stripe/stripe-go	0.176s
ok  	github.com/stripe/stripe-go/account	0.081s
ok  	github.com/stripe/stripe-go/applepaydomain	(cached)
ok  	github.com/stripe/stripe-go/balance	0.106s
ok  	github.com/stripe/stripe-go/bankaccount	0.129s
ok  	github.com/stripe/stripe-go/bitcoinreceiver	0.086s
ok  	github.com/stripe/stripe-go/bitcointransaction	(cached)
ok  	github.com/stripe/stripe-go/card	0.267s
ok  	github.com/stripe/stripe-go/charge	0.089s
ok  	github.com/stripe/stripe-go/client	0.035s
ok  	github.com/stripe/stripe-go/countryspec	(cached)
ok  	github.com/stripe/stripe-go/coupon	(cached)
ok  	github.com/stripe/stripe-go/customer	0.085s
ok  	github.com/stripe/stripe-go/discount	(cached)
ok  	github.com/stripe/stripe-go/dispute	0.072s
ok  	github.com/stripe/stripe-go/ephemeralkey	(cached)
ok  	github.com/stripe/stripe-go/event	(cached)
ok  	github.com/stripe/stripe-go/exchangerate	(cached)
ok  	github.com/stripe/stripe-go/fee	0.092s
ok  	github.com/stripe/stripe-go/feerefund	0.123s
ok  	github.com/stripe/stripe-go/filelink	(cached)
ok  	github.com/stripe/stripe-go/fileupload	(cached)
ok  	github.com/stripe/stripe-go/form	(cached)
ok  	github.com/stripe/stripe-go/invoice	0.127s
ok  	github.com/stripe/stripe-go/invoiceitem	0.074s
ok  	github.com/stripe/stripe-go/issuerfraudrecord	0.134s
ok  	github.com/stripe/stripe-go/issuing/authorization	0.162s
ok  	github.com/stripe/stripe-go/issuing/card	(cached)
ok  	github.com/stripe/stripe-go/issuing/cardholder	(cached)
ok  	github.com/stripe/stripe-go/issuing/dispute	0.160s
ok  	github.com/stripe/stripe-go/issuing/transaction	0.123s
ok  	github.com/stripe/stripe-go/loginlink	(cached)
ok  	github.com/stripe/stripe-go/order	0.157s
ok  	github.com/stripe/stripe-go/orderreturn	0.111s
ok  	github.com/stripe/stripe-go/paymentintent	0.131s
ok  	github.com/stripe/stripe-go/paymentsource	0.099s
ok  	github.com/stripe/stripe-go/payout	0.078s
ok  	github.com/stripe/stripe-go/plan	(cached)
ok  	github.com/stripe/stripe-go/product	(cached)
ok  	github.com/stripe/stripe-go/recipient	0.095s
ok  	github.com/stripe/stripe-go/recipienttransfer	(cached) [no tests to run]
ok  	github.com/stripe/stripe-go/refund	0.076s
ok  	github.com/stripe/stripe-go/reversal	0.089s
ok  	github.com/stripe/stripe-go/sigma/scheduledqueryrun	(cached)
ok  	github.com/stripe/stripe-go/sku	(cached)
ok  	github.com/stripe/stripe-go/source	(cached)
ok  	github.com/stripe/stripe-go/sourcetransaction	(cached)
ok  	github.com/stripe/stripe-go/sub	0.121s
ok  	github.com/stripe/stripe-go/subitem	(cached)
ok  	github.com/stripe/stripe-go/testing	(cached)
ok  	github.com/stripe/stripe-go/threedsecure	0.067s
ok  	github.com/stripe/stripe-go/token	0.081s
ok  	github.com/stripe/stripe-go/topup	0.062s
ok  	github.com/stripe/stripe-go/transfer	0.056s
ok  	github.com/stripe/stripe-go/usagerecord	(cached)
ok  	github.com/stripe/stripe-go/webhook	(cached)

Copy link

@enugent-stripe enugent-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I haven't deployed to the Go library so I don't know if there's anything extra you need to concern yourself with on that front, but the code looks dope.

// BitcoinReceiverUpdateParams is the set of parameters that can be used when
// updating a BitcoinReceiver. For more details see
// https://stripe.com/docs/api/#update_bitcoin_receiver.
type BitcoinReceiverUpdateParams struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove BitcoinReceiverParams as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, doesn't look like we need that still.

@brandur-stripe
Copy link
Contributor

Nice! And one more minor upfront comment that I try to give everyone at least once: we generally try to maintain better commit hygiene on the public repos than what you might see internally. Most of us who contribute regularly use git commit --amend and/or git rebase to squash commits/messages down into something cohesive before merge — and usually to one commit per PR.

You can also us the "squash" button when merging, but usually the commit messages turn out better when written as a unified whole by their original author.

@tomer-stripe
Copy link
Contributor Author

That makes sense! Will squash the commits and re-push

@tomer-stripe tomer-stripe force-pushed the tomer-remove-editable-bitcoin-receiver-actions branch from ff2d73f to d10e8f5 Compare August 17, 2018 00:44
@tomer-stripe tomer-stripe force-pushed the tomer-remove-editable-bitcoin-receiver-actions branch from d10e8f5 to ca5d762 Compare August 17, 2018 17:00
@brandur-stripe brandur-stripe merged commit ba584a7 into master Aug 17, 2018
@brandur-stripe
Copy link
Contributor

Released as 41.0.0.

@brandur-stripe brandur-stripe deleted the tomer-remove-editable-bitcoin-receiver-actions branch August 17, 2018 23:12
nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
* boilerplate script

* added script and started readme updates

* fixed script

* updated readme

* added back prod env context

* added additional snipet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants