-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove editable bitcoin receiver actions #659
Remove editable bitcoin receiver actions #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I haven't deployed to the Go library so I don't know if there's anything extra you need to concern yourself with on that front, but the code looks dope.
bitcoinreceiver.go
Outdated
// BitcoinReceiverUpdateParams is the set of parameters that can be used when | ||
// updating a BitcoinReceiver. For more details see | ||
// https://stripe.com/docs/api/#update_bitcoin_receiver. | ||
type BitcoinReceiverUpdateParams struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove BitcoinReceiverParams
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, doesn't look like we need that still.
Nice! And one more minor upfront comment that I try to give everyone at least once: we generally try to maintain better commit hygiene on the public repos than what you might see internally. Most of us who contribute regularly use You can also us the "squash" button when merging, but usually the commit messages turn out better when written as a unified whole by their original author. |
That makes sense! Will squash the commits and re-push |
ff2d73f
to
d10e8f5
Compare
d10e8f5
to
ca5d762
Compare
Released as 41.0.0. |
* boilerplate script * added script and started readme updates * fixed script * updated readme * added back prod env context * added additional snipet
Removes the ability to use
New
andUpdate
for bitcoin receivers. Tests pass!