Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BackendConfiguration to BackendImplementation #649

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Aug 6, 2018

I recently introduced BackendConfig to give users a way of fine-tuning
a backend that's created. Unfortunately, that produced a close name
collision with the existing BackendConfiguration, which isn't really a
configuration, but more of the main implementation of the Backend
interface.

Here we rename BackendConfiguration to BackendImplementation to make
this less confusing. It's a breaking change, but I have to do a major
release as part of #648 anyway, so it's not a bad time to do it.

I recently introduced `BackendConfig` to give users a way of fine-tuning
a backend that's created. Unfortunately, that produced a close name
collision with the existing `BackendConfiguration`, which isn't really a
configuration, but more of the main implementation of the `Backend`
interface.

Here we rename `BackendConfiguration` to `BackendImplementation` to make
this less confusing. It's a breaking change, but I have to do a major
release as part of #648 anyway, so it's not a bad time to do it.
@brandur-stripe brandur-stripe merged commit da8c1a3 into master Aug 6, 2018
@brandur-stripe brandur-stripe deleted the brandur-backend-rename branch August 6, 2018 22:31
@brandur-stripe
Copy link
Contributor

Released as 40.0.0.

nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
* Setting error emails properly

* Fetch KMS right away

* Notes on packaging and remote sites

* Managed package links

* JIRA link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants