Add support for ScheduledQueryRun #637
Conversation
| ) | ||
|
|
||
| func TestSigmaScheduledQueryRunGet(t *testing.T) { | ||
| t.Skip("skipping test as stripe-mock does not support this resource") |
There was a problem hiding this comment.
It would be really cool if we could add some way to stub requests like we do in other libraries!
There was a problem hiding this comment.
Yes, that would be cool! Mocking isn't really possible in Go, but I think we can accomplish something similar with a helper to boot up a little JSON test server that responds with a blob you can hand it.
In this case though, I think we should make sure that stripe-mock supports scheduled query runs. I'm just winding that through the backend now.
There was a problem hiding this comment.
Okay, can you try bumping stripe-mock to 0.24.0 and seeing if you can activate these tests? Thanks!
ptal @remi-stripe
There was a problem hiding this comment.
oh neat, thanks for shipping this one!
remi-stripe
force-pushed
the
remi-add-scheduled-query-run
branch
from
6def002 to
d8ac125
Compare
|
@brandur-stripe fixed, PTAL! |
|
LGTM. Thanks! |
|
Released as 37.0.0. |
r? @brandur-stripe
cc @stripe/api-libraries