Fix encoding of list params for bank accounts and cards #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
Jul 24, 2018
card_test.go
Outdated
|
|
||
| // Adds `object` for customer (this will hit the sources endpoint) | ||
| { | ||
| params := &CardListParams{Account: String("acct_123")} |
There was a problem hiding this comment.
This should be Customer: String("cus_123") instead
There was a problem hiding this comment.
Oops! Thank you. Fixed.
| form.AppendTo(body, params) | ||
| t.Logf("body = %+v", body) | ||
| assert.Equal(t, []string{"bank_account"}, body.Get("object")) | ||
| } |
There was a problem hiding this comment.
should you be testing Account and Customer like you do for cards?
There was a problem hiding this comment.
Yeah, I skipped it because the same conditional branch just adds object regardless of the circumstances, but I guess it can't hurt to be explicit. Broke it into two test cases like cards.
Fixes a bug discovered in #632 whereby because we were manually adding a filter like `?object=bank_account` to the end of paths, we'd clash with the `form` package's attempt at an encoding if both came into play. This would have the effect of producing an invalid URL like this: ``` /accounts/acc_xxxxxx/external_accounts?object=bank_account?limit=1&starting_after=ba_xxxxxx ``` (Note the multiple `?`s in the query string.) Here we stop manually adding filters to URL paths and move them into a custom `AppendTo` override for the `form` package. Bank accounts and cards were the only places that we were doing this, so only they were affected. We also add tests to make sure that we're doing the right thing.
brandur-stripe
force-pushed
the
brandur-fix-list-params-encoding
branch
from
8420692 to
d90d28b
Compare
remi-stripe
approved these changes
Jul 24, 2018
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.10274 to 0.5.10286. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug discovered in #632 whereby because we were manually adding a
filter like
?object=bank_accountto the end of paths, we'd clash withthe
formpackage's attempt at an encoding if both came into play. Thiswould have the effect of producing an invalid URL like this:
(Note the multiple
?s in the query string.)Here we stop manually adding filters to URL paths and move them into a
custom
AppendTooverride for theformpackage. Bank accounts andcards were the only places that we were doing this, so only they were
affected.
We also add tests to make sure that we're doing the right thing.
Fixes #632.
r? @remi-stripe
cc @stripe/api-libraries