Add extra params/properties for Level III on Charge #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for tracking that down. |
|
Released as 35.7.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Cache service implementation * moved order.rb translator over to cache service * rubo * in progress * reverted amendment queries * reverted other amendments function * finished out swaps * added tweak for fetch * added toggle * turned off for order amendments * cop * cleaned up cache and default to reaching out to salesforce * cop * added namespace * added comment * small adjustments * turned on for amendments and added logging * cop * added cache create for tests * re-disabled for amendments * added cache fall back for nested search * cop * fixed tests * fixed tests * addressed pr feedback * cop * improved logs * fixed helper * typecheck * Update lib/stripe-force/cache_service.rb Co-authored-by: mbianco-stripe <[email protected]> * Update lib/stripe-force/cache_service.rb Co-authored-by: mbianco-stripe <[email protected]> * addressed PR feedback * added memoized method for cache service * cop * added feature falg * cop * added throw for CI * tc * gutted amendment disablement * added second run with caching disabled * added full seperate build step * fixed config * fixed env conditional * Update test/support/common_helpers.rb Co-authored-by: mbianco-stripe <[email protected]> * Update lib/stripe-force/translate/translate.rb Co-authored-by: mbianco-stripe <[email protected]> * Update lib/stripe-force/translate/price.rb Co-authored-by: mbianco-stripe <[email protected]> * Update lib/stripe-force/cache_service.rb Co-authored-by: mbianco-stripe <[email protected]> * Update lib/stripe-force/translate/translate.rb Co-authored-by: mbianco-stripe <[email protected]> * Update lib/stripe-force/translate/order.rb Co-authored-by: mbianco-stripe <[email protected]> * Update lib/stripe-force/translate/price.rb Co-authored-by: mbianco-stripe <[email protected]> * pulled reports and throw into one method * cop * misplaced parameters * attempting mapping merging * just added to existing anchor * tweaked * added back * adjusted anchor * removed from clean * began tests * added tests, currently failing for amendment * added early exit for global cache disabled test runs * made test deterministic * added metadata to error message for determining what is missing * cop * removed merge mistake Co-authored-by: Brennen Ryder <[email protected]> Co-authored-by: brennen-stripe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brandur-stripe turns out you were right and those are supported, and the docs are getting updated.
r? @brandur-stripe
cc @stripe/api-libraries