Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters for the upcoming invoice #601

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

remi-stripe
Copy link
Contributor

When retrieving the upcoming invoice, you can now pass

  • a new coupon
  • a list of extra invoice items
  • billing cycle anchor or trial from plan
  • subscription's tax_percent

This fixes #600

r? @brandur-stripe
cc @stripe/api-libraries

When retrieving the upcoming invoice, you can now pass
- a new coupon
- a list of extra invoice items
- billing cycle anchor or trial from plan
- subscription's tax_percent
@brandur-stripe
Copy link
Contributor

Arg, the TaxPercent versus SubscriptionTaxPercent is a little unfortunately :/ I guess the shared parameter structs (between all API functions for a given resource) work pretty well pretty much everywhere else though.

LGTM. Thanks for doing the extra digging.

@brandur-stripe brandur-stripe merged commit 6a3f721 into master Jun 22, 2018
@remi-stripe remi-stripe deleted the remi-add-tax-percent-upcoming branch February 3, 2019 00:14
nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
* Sandbox setup improvements

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoice preview unknown parameter: tax_percent
2 participants