Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket_size -> divide_by #576

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Fix bucket_size -> divide_by #576

merged 1 commit into from
Jun 7, 2018

Conversation

mholt
Copy link
Contributor

@mholt mholt commented Jun 7, 2018

Fixes #575. Not much to explain here, methinks. :)

@remi-stripe
Copy link
Contributor

Thanks of making the change. This one is weird, I could have sworn it was called bucket_size instead of divide_by a week ago.

@brandur-stripe while it's a breaking change, it also did not work so we likely can release it as a minor version.

@brandur-stripe
Copy link
Contributor

Thanks @mholt!

Remi — agree on not cutting a major for this change. I'll put a note about it in the changelog.

@brandur-stripe brandur-stripe merged commit e5045d0 into stripe:master Jun 7, 2018
@brandur-stripe
Copy link
Contributor

Released as 32.3.0.

@mholt
Copy link
Contributor Author

mholt commented Jun 7, 2018

Great! Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants