Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invoice's pdf and hosted url #571

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

remi-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

invoice.go Outdated
@@ -90,6 +90,8 @@ type Invoice struct {
DueDate int64 `json:"due_date"`
EndingBalance int64 `json:"ending_balance"`
Forgiven bool `json:"forgiven"`
HostedInvoiceURL string `json:"hosted_invoice_url"`
InvoicePDF string `json:"invoice_pdf"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nit, but I think this should be below ID for it to line up alphabetically.

@brandur-stripe
Copy link
Contributor

Thanks Remi!

@brandur-stripe
Copy link
Contributor

Just a quick bump on this one — I suspect the notification may have been accidentally archived in your inbox during the churn today.

@remi-stripe remi-stripe force-pushed the remi-add-invoice-properties branch from 18d322d to c5bead4 Compare June 7, 2018 00:14
@remi-stripe
Copy link
Contributor Author

ah yes, totally missed this one. The other two libraries (dotnet and java) put id/object at the top I think so I missed this.
PTAL.

@brandur-stripe brandur-stripe merged commit 512325f into master Jun 7, 2018
@brandur-stripe brandur-stripe deleted the remi-add-invoice-properties branch June 7, 2018 00:27
@brandur-stripe
Copy link
Contributor

Released as 32.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants