issuerfraudrecord: add issuerfraudrecord package #552
Conversation
issuerfraudrecord.go
Outdated
| MadeWithLostCard FraudType = "made_with_lost_card" | ||
| MadeWithStolenCard FraudType = "made_with_stolen_card" | ||
| Misc FraudType = "misc" | ||
| UnauthorizedUseOfCard FraudType = "unauthorized_use_of_card" |
There was a problem hiding this comment.
Would you mind prefixing all of these with FraudType? The reason is that this file is in the top-level package and we want to minimize collisions (a constant like Misc has a decent likelihood of reappearing somewhere else).
There was a problem hiding this comment.
Should we go with IssuerFraudTypeXXX?
There was a problem hiding this comment.
Yes, good point. That's even better. Maybe change the type definition FraudType to IssuerFraudType as well.
There was a problem hiding this comment.
Yep, definitely, done!
|
Thanks Matt! Can you try upgrading stripe-mock (see instructions at the very bottom of |
|
@brandur-stripe I think this is ready to go! |
|
LGTM. |
|
Released as 30.7.0. |
r? @brandur-stripe
cc @fay-stripe
This is the analogous Go update for stripe/stripe-ruby#645. Note that it's pending an update to
stripe-mock(depends on OpenAPI spec rev).