Flexible billing primitives #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plan_test.go
Outdated
| {"tiers[0][amount]", &PlanParams{Tiers: tiers}, strconv.FormatUint(123, 10)}, | ||
| {"tiers[0][up_to]", &PlanParams{Tiers: tiers}, strconv.FormatUint(321, 10)}, | ||
| {"tiers[1][amount]", &PlanParams{Tiers: tiers}, strconv.FormatUint(123, 10)}, | ||
| {"tiers[1][up_to]", &PlanParams{Tiers: tiers}, "inf"}, |
There was a problem hiding this comment.
Sorry for the nit, but would you mind just alphabetizing these test cases by their leading string?
usagerecord/client_test.go
Outdated
| Quantity: 123, | ||
| Timestamp: now, | ||
| Action: stripe.UsageRecordParamsActionIncrement, | ||
| SubscriptionItem: "si_abc123", |
There was a problem hiding this comment.
Just per convention, mind just changing this to si_123?
|
Added two minor asks, but otherwise LGTM. Would you also mind just rebasing this into one commit with a good title/description? We've been trying to improve our commit hygiene more recently. Thanks! |
alexander-stripe
force-pushed
the
alexander/flexible-billing
branch
from
e20dba5 to
4fdc1ee
Compare
|
Thanks for taking a look! Done. |
|
Nice! Thanks for the quick fixes. |
|
Released as 30.3.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Extract subscription term from quote * Updating test to not use custom price field * Adjusting tests to pass on missing term on the order item level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR ported from internal internal GHE.
Adds flexible billing primitives to the SDK for beta functionality.