Add missing MaidenName, PersonalID, PersonalIDProvided fields to Owner #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfriedel
force-pushed
the
owner-add-missing-fields
branch
from
b191f2b to
fe48405
Compare
sfriedel
changed the title
account.go
Outdated
| Last string `json:"last_name" form:"last_name"` | ||
| MaidenName string `json:"maiden_name" form:"maiden_name"` | ||
| PersonalID string `json:"-" form:"personal_id_number"` | ||
| PersonalIDProvided bool `json:"personal_id_number_provided" form:"-"` |
There was a problem hiding this comment.
Would you mind:
(1) Change PersonalID to PersonalIDNumber — we're trying to move away from the arbitrary shorthands in stripe-go.
(2) Likewise change PersonalIDProvided to PersonalIDNumberProvided.
|
Left a minor comment, but thanks a lot for taking a crack at this! |
…NumberProvided in Owner
|
@brandur-stripe I renamed the fields. Please have another look |
|
Thanks! |
|
Released as 29.3.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Initial order amendment is working * Adding contract to sf object ID helper * Adding sf contract/amendment constants * Improve get_related debugger call * Adding wait_util helper for contract-related tests * Initial order amendment implementation * Adding Id field to restforce types * Type fix * Fix stripe_params access on internal line item structure * Removing unneeded dirty! call * Missing subscription schedule fields * Stop updating connector_settings on existing users * Handle cancellation and other use cases * More order amendment tests * Auto-open stripe dashboard in debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there are some fields missing on the Owner type that are defined in the API documentation.
This PR adds those fields to the Owner type.