Update subscriptions with changes to billing_cycle_anchor
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the following changes: * Adds `BillingCycleAnchorUnchanged` to `SubParams` to support the new `unchanged` value for this field. * Adds `BillingCycleAnchor` to the `Sub` response (which was previously not present).
|
I don't have any context here... I'm not sure you meant to r me? |
|
@oliver-stripe Sorry, one letter off in the autocomplete haha. Added Olivier instead! |
|
👍 |
benbuckman-stripe
approved these changes
Feb 9, 2018
|
lgtm! |
|
Thanks guys! |
|
Released as 28.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following changes:
BillingCycleAnchorUnchangedtoSubParamsto support the newunchangedvalue for this field.BillingCycleAnchorto theSubresponse (which was previouslynot present).
Unfortunately the new fields were just a little bit longer in naming than anything
in there before, so
gofmtmade the diff a bit of a mess. It's much easier toview the changes using the "no whitespace" link:
https://github.com/stripe/stripe-go/pull/517/files?w=1
r? @ob-stripe (I'll also ask someone on the Subs team to review as well.)