Rename language fields in Stripe's user agent to start with lang
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
force-pushed
the
brandur-rename-language
branch
from
6eee60c to
47840b0
Compare
I noticed this as I was looking at a dashboard that @ob-stripe produced today. Other languages send language and language version as `lang` and `lang_version` while we were using the fully expanded `language_*` here. I'm changing it here for consistency with other libraries, but I'm also going to patch the server because there are so many Go libraries out there that could potentially be reporting if we supported both styles.
brandur-stripe
force-pushed
the
brandur-rename-language
branch
from
47840b0 to
c096661
Compare
|
Oh, nice find! I actually checked in Splunk that the library was sending the values, but failed to notice the lgtm 👍 |
ob-stripe
approved these changes
Nov 2, 2017
|
Thanks! |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) from 0.5.10090 to 0.5.10095. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this as I was looking at a dashboard that @ob-stripe produced today.
Other languages send language and language version as
langandlang_versionwhile we were using the fully expanded
language_*here. I'm changing it herefor consistency with other libraries, but I'm also going to patch the server
because there are so many Go libraries out there that could potentially be
reporting if we supported both styles.
r? @ob-stripe