Make account_holder_name/account_holder_type truly optional
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encoding a bank account we shouldn't send `account_holder_name` or `account_holder_type` unless they're given values. Sending an empty value will cause an API error in cases where the request would have otherwise been valid. Fixes the other part of #485.
|
Thanks Remi. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* added phase object to open spec -added phase object to open spec -cleaned up data mapper html * adding loading state in js back * removing garbage line in html * Fixing duplicated code in open api spec * Update sfdx/force-app/main/default/lwc/dataMappingStep/dataMappingStep.js Co-authored-by: mbianco-stripe <[email protected]> * updated switch breaks to returns based on PR comments * Add TODO comment Co-authored-by: Mike Bianco <[email protected]> Co-authored-by: mbianco-stripe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encoding a bank account we shouldn't send
account_holder_nameoraccount_holder_typeunless they're given values. Sending an emptyvalue will cause an API error in cases where the request would have
otherwise been valid.
Fixes the other part of #485.
r? @remi-stripe