Support for redirect.failure_reason attribute #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (thanks for handling!) |
source.go
Outdated
| RedirectFlowFailureReasonUserAbort RedirectFlowFailureReason = "user_abort" | ||
| RedirectFlowFailureReasonDeclined RedirectFlowFailureReason = "declined" | ||
| RedirectFlowFailureReasonProcessingError RedirectFlowFailureReason = "processing_error" | ||
| ) |
There was a problem hiding this comment.
Minor OB, but we recently went through and alphabetized everything in the library that we could find. Unfortunately there's no CI check on this, but would you mind giving this list of consts the same treatment? Thanks!
ob-stripe
force-pushed
the
ob-failure-reason
branch
from
e4d2955 to
9952486
Compare
|
Released as 28.1.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
…hout saving (#471) * added cancel modal instead of error toast when trying to nav away from tab without saving * added in navigation after selecting leave in cancel modal * adding tracked var back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries @stan-stripe
Adds support for the new
redirect.failure_reasonattribute on sources.