Add form annotation for cvc in CardParams
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing form annotation for `cvc` in CardParams. This isn't used when creating cards directly (that gets passed through a special `AppendTo*` that already encodes a `cvc`), but is important when creating a token with a card. Fixes #464.
|
I think this one is pretty uncontentious because it's right in the "create token" example for Go, so going to self-approve since I'm out a little later today. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.10063 to 0.5.10072. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing form annotation for
cvcin CardParams. This isn't usedwhen creating cards directly (that gets passed through a special
AppendTo*that already encodes acvc), but is important whencreating a token with a card.
Fixes #464.