Move Metadata from embedded Params onto specific Params structs
#1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
requested review from
a team and
anniel-stripe
and removed request for
a team
anniel-stripe
approved these changes
Apr 13, 2023
richardm-stripe
force-pushed
the
richardm-hoist-metadata
branch
from
fc91dfc to
d220630
Compare
richardm-stripe
force-pushed
the
sdk-release/next-major
branch
from
b36d2c2 to
b05fb41
Compare
This was referenced Aug 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users occasionally think that
Metadatais missing from stripe-go, or don't see how to set it, because it's difficult to find inside the embeddedParamsstruct.This PR
Metadataexplicitly to each Params struct for a part of the API that supports Metadata, along with anAddMetadatamethod.MetadataandAddMetadataon the embedded params struct..Callto error if both the explicit Metadata and the deprecated embedded Metadata are set.Best to review the first two logic-ful commits first:
I think this is non-breaking, but as we are planning a major release soon it ought to go there.
Fixes #1456, #1599, #1468, #1362, #1251, #1233, ... etc.