Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to go reference path #1575

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

anniel-stripe
Copy link
Contributor

The link to the Go reference docs https://pkg.go.dev/github.com/stripe/stripe-go/ shows v70 by default, instead of the latest version. This fixes the link to be https://pkg.go.dev/github.com/stripe/stripe-go/v74 (verified that running make update-version updates this README link with the major version).

Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some logic to the Makefile to automatically update this version.

Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@anniel-stripe anniel-stripe merged commit 61770df into master Nov 22, 2022
@anniel-stripe anniel-stripe deleted the anniel-update-readme branch November 22, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants