Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing verify with micro-deposits next action #1562

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

epelc
Copy link
Contributor

@epelc epelc commented Oct 22, 2022

The next action type documented a verify_with_microdeposits value but did not have a constant for it.

Add PaymentIntentNextActionTypeVerifyWithMicrodeposits as a constant for this value.

The next action type documented a `verify_with_microdeposits` value but did not have a constant for it.

Add `PaymentIntentNextActionTypeVerifyWithMicrodeposits` as a constant for this value.
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2022

CLA assistant check
All committers have signed the CLA.

@epelc
Copy link
Contributor Author

epelc commented Oct 22, 2022

Also proof it is an actual value. From our stripe webhooks

image

@pakrym-stripe
Copy link
Contributor

Sorry for the delayed response and thank you for the contribution. This looks great. We found a bug in the generator that caused us to skip this value I pushed another commit that adds more missing values.

@pakrym-stripe pakrym-stripe self-assigned this Jan 20, 2023
@pakrym-stripe pakrym-stripe merged commit 4c59cce into stripe:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants