Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Updates #1532

Merged
merged 2 commits into from
Aug 23, 2022
Merged

API Updates #1532

merged 2 commits into from
Aug 23, 2022

Conversation

dcr-stripe
Copy link
Contributor

@dcr-stripe dcr-stripe commented Aug 23, 2022 •
edited
Loading

Codegen for openapi v184.
r? @pakrym-stripe
cc @stripe/api-libraries

Changelog

  • Change type of TreasuryOutboundTransferDestinationPaymentMethod from string to nullable(string)
  • Change return type of FundCashBalance method on Customer from Customer to CustomerCashBalanceTransaction
    • This is technically a breaking change, but this return type was actually incorrect and so the result of this method did not deserialize correctly.
  • Change return type of RetrieveFeatures and UpdateFeatures methods on TreasuryFinancialAccount from TreasuryFinancialAccount to TreasuryFinancialAccountFeatures
    • This is technically a breaking change, but this return type was actually incorrect and so the result of this method did not deserialize correctly.

@pakrym-stripe
Copy link
Contributor

The changelog entry is wrong. Why are we not seeing the CashBalanceTransaction change here?

pakrym-stripe
pakrym-stripe requested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff seems to be missing the cashBalanceTransaction change.

@dcr-stripe dcr-stripe force-pushed the latest-codegen-master branch 2 times, most recently from 249e0c6 to b06f9ff Compare August 23, 2022 18:36
@dcr-stripe dcr-stripe force-pushed the latest-codegen-master branch from b06f9ff to d1084fe Compare August 23, 2022 18:47
@dcr-stripe
Copy link
Contributor Author

@pakrym-stripe PTAL - updated changelog and regenerated.

@dcr-stripe dcr-stripe merged commit bf00487 into master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-stripe pakrym-stripe pakrym-stripe approved these changes

Assignees

@dcr-stripe dcr-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcr-stripe @pakrym-stripe