Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1344

Merged
merged 2 commits into from
Sep 24, 2021
Merged

API Updates #1344

merged 2 commits into from
Sep 24, 2021

Conversation

richardm-stripe
Copy link
Contributor

Codegen for openapi 0ac8805.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add support for AmountAuthorized and OvercaptureSupported on ChargePaymentMethodDetailsCardPresent

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but seems the test will need a change.

Currency: stripe.String(string(stripe.CurrencyUSD)),
}
result, _ := customerbalancetransaction.New(params)
result, _ := customerbalancetransaction.New("cus_xxxxxxxxxxxxx", nil)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh - seems like something is broken in the test now?

@richardm-stripe
Copy link
Contributor Author

Reverted the bad test.

@richardm-stripe richardm-stripe merged commit b97475c into master Sep 24, 2021
@richardm-stripe richardm-stripe deleted the latest-codegen branch September 28, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants