-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for search API #1324
Conversation
r? @dcr-stripe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - thanks Pavel! Just some small changes and then I think we're good to go.
// SetStripeAccount sets a value for the Stripe-Account header. | ||
func (p *SearchParams) SetStripeAccount(val string) { | ||
p.StripeAccount = &val | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we actually need this for search infrastructure right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is consistent with List params. A way to set stripe account on the search request.
Forgot that I worked on this PR |
r? @pakrym-stripe since you're picked it up again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Pavel!
r? @richardm-stripe @dcr-stripe
Summary
Add support for search results by adding a new iterator. The new iterator functionality and interface is very similar to existing list iterator, so it should be very familiar to use.
Testing