Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for search API #1324

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Add support for search API #1324

merged 6 commits into from
Mar 16, 2022

Conversation

akalinin-stripe
Copy link
Contributor

r? @richardm-stripe @dcr-stripe

Summary

Add support for search results by adding a new iterator. The new iterator functionality and interface is very similar to existing list iterator, so it should be very familiar to use.

Testing

  • Unit tests for search iterator
  • Unit tests against stripe-mock (forthcoming with actual API update)
  • Testing via a small test program against the actual search API

@pakrym-stripe pakrym-stripe reopened this Mar 15, 2022
@pakrym-stripe
Copy link
Contributor

r? @dcr-stripe

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - thanks Pavel! Just some small changes and then I think we're good to go.

Comment on lines +79 to +82
// SetStripeAccount sets a value for the Stripe-Account header.
func (p *SearchParams) SetStripeAccount(val string) {
p.StripeAccount = &val
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually need this for search infrastructure right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with List params. A way to set stripe account on the search request.

search_params.go Outdated Show resolved Hide resolved
search_params.go Outdated Show resolved Hide resolved
@akalinin-stripe
Copy link
Contributor Author

Forgot that I worked on this PR

@akalinin-stripe
Copy link
Contributor Author

r? @pakrym-stripe since you're picked it up again

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Pavel!

@pakrym-stripe pakrym-stripe merged commit 8fef140 into master Mar 16, 2022
@remi-stripe remi-stripe deleted the akalinin-go-search branch September 28, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants