Stop using uploads.stripe.com for the files backend. #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to using `files.stripe.com`. While both point to the same location, all other SDKs use the newer `files.stripe.com`. This also removes some confusion in this code - both constants were defined but we were using the older constant.
|
Looks good to me |
|
Do we consider this breaking? I think the URL to the stripe api is in one sense an "internal to Stripe" implementation detail, but then I do anticipate there could be users whitelisting urls specifically for egress in their infra... |
|
@richardm-stripe the egress part is a good point but we didn't treat this as a breaking change in other client libraries at least so I think it's fine to merge as patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
Move to using
files.stripe.com. While both point to the same location, all other SDKs use the newerfiles.stripe.com. This also removes some confusion in this code - both constants were defined but we were using the older constant.