Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1318

Merged
merged 1 commit into from
Jul 21, 2021
Merged

API Updates #1318

merged 1 commit into from
Jul 21, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Jul 21, 2021

Codegen for openapi adfc63f.
r? @richardm-stripe
cc @stripe/api-libraries

Changelog

  • Add support for Wallet on IssuingTransaction
  • Add support for Ideal on PaymentIntentPaymentMethodOptionsParams, PaymentIntentPaymentMethodOptionsParams, PaymentIntentConfirmPaymentMethodOptionsParams, and PaymentIntentPaymentMethodOptions

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mentioned removing errors for constants but you didn't. IMO removing is a breaking change we should defer to the next major so it's best anyway

@dcr-stripe
Copy link
Contributor

Spoke with Richard - OK to remove the error removal from the changelog as it's not in the code.

@dcr-stripe dcr-stripe merged commit 5b88c66 into master Jul 21, 2021
@dcr-stripe dcr-stripe deleted the latest-codegen branch July 21, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants