-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming requests #1283
Add streaming requests #1283
Conversation
a3f80d0
to
9abb082
Compare
36a222a
to
d8bc459
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Mainly minor comments - thanks Richard!
86ec5ab
to
672f758
Compare
r? @dcr-stripe thanks for the great review! Went a little further in the refactoring/reducing duplication and addressed all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks Richard! 🥳 Just one comment about naming. Thanks for all the work on this!!
Notify
r? @dcr-stripe
cc @stripe/api-libraries
Description
Implements support for streaming requests.
How this will be used
and then the user can
It might help to review this commit-by-commit. There's some refactoring into helper functions.