Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegens nine more
client.go
files.All changes except for two are formatting/ordering/variable naming/docstring changes that have no behavior effect.
Those two are:
errors.New(...)
withfmt.Errorf(...)
-- shouldn't make a difference -- these functions behave essentially identicallyusagerecordsummary/client.go
I move the assignment ofpath := ...
outside of the innerIter
to be consistent with how the other Iter methods are written. This is technically a behavior change: with the previous code, if you mutatedlistParams.SubscriptionID
halfway through pagination, things would switch to making requests on a different subscription -- in the new code mutating listParams will have no effect. I can't imagine anybody actually desires the old behavior.