Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen more client.go files #1276

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Codegen more client.go files #1276

merged 1 commit into from
Apr 19, 2021

Conversation

richardm-stripe
Copy link
Contributor

Codegens nine more client.go files.

All changes except for two are formatting/ordering/variable naming/docstring changes that have no behavior effect.

Those two are:

  • I replaced one errors.New(...) with fmt.Errorf(...) -- shouldn't make a difference -- these functions behave essentially identically
  • In usagerecordsummary/client.go I move the assignment of path := ... outside of the inner Iter to be consistent with how the other Iter methods are written. This is technically a behavior change: with the previous code, if you mutated listParams.SubscriptionID halfway through pagination, things would switch to making requests on a different subscription -- in the new code mutating listParams will have no effect. I can't imagine anybody actually desires the old behavior.

@richardm-stripe richardm-stripe merged commit 183ca9e into master Apr 19, 2021
@richardm-stripe richardm-stripe deleted the richardm-go-codegen-6 branch April 19, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants