Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ACSS debit payment method #1275

Merged
merged 5 commits into from
Apr 12, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Apr 12, 2021

  • Add support for acss_debit as value for PaymentMethodType.
  • Add support for ACSSDebit on PaymentMethod, PaymentMethodParams, PaymentIntentPaymentMethodOptions, PaymentIntentPaymentMethodOptionsParams, MandatePaymentMethodDetails, SetupIntentPaymentMethodOptions, and SetupIntentPaymentOptionsParams.
  • Add support for ACSSDebitPayments on AccountCapabilities
  • Add support for PaymentMethodOptions on CheckoutSession
  • Add support for verify_with_microdeposits and use_stripe_sdk on PaymentIntentNextAction and SetupIntentNextAction

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since the changes all look correct and it's just missing docstrings

checkout_session.go Show resolved Hide resolved
@@ -313,12 +360,25 @@ type PaymentIntentNextActionRedirectToURL struct {
URL string `json:"url"`
}

// PaymentIntentNextActionUseStripeSDK represents the resource for the next action of typee "use_stripe_sdk".
type PaymentIntentNextActionUseStripeSDK struct {
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adding this one expected? Not opposed since it's really a thing but I didn't expect it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, forgot to call that out. Codegen revealed it was missing so I figured I'd add it alongside verify_with_microdeposits.

@richardm-stripe richardm-stripe force-pushed the richardm-add-acss-debit-support branch from 65a26db to e893613 Compare April 12, 2021 23:25
@richardm-stripe
Copy link
Contributor Author

richardm-stripe commented Apr 12, 2021

You were totally right, Currency was missing! (added in 74d9521)
re-r? @remi-stripe

@richardm-stripe richardm-stripe merged commit 1bb71f1 into master Apr 12, 2021
@richardm-stripe richardm-stripe deleted the richardm-add-acss-debit-support branch April 12, 2021 23:58
nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants