-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ACSS debit payment method #1275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving since the changes all look correct and it's just missing docstrings
@@ -313,12 +360,25 @@ type PaymentIntentNextActionRedirectToURL struct { | |||
URL string `json:"url"` | |||
} | |||
|
|||
// PaymentIntentNextActionUseStripeSDK represents the resource for the next action of typee "use_stripe_sdk". | |||
type PaymentIntentNextActionUseStripeSDK struct { | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is adding this one expected? Not opposed since it's really a thing but I didn't expect it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, forgot to call that out. Codegen revealed it was missing so I figured I'd add it alongside verify_with_microdeposits
.
65a26db
to
e893613
Compare
You were totally right, Currency was missing! (added in 74d9521) |
acss_debit
as value forPaymentMethodType
.ACSSDebit
onPaymentMethod
,PaymentMethodParams
,PaymentIntentPaymentMethodOptions
,PaymentIntentPaymentMethodOptionsParams
,MandatePaymentMethodDetails
,SetupIntentPaymentMethodOptions
, andSetupIntentPaymentOptionsParams
.ACSSDebitPayments
onAccountCapabilities
PaymentMethodOptions
onCheckoutSession
verify_with_microdeposits
anduse_stripe_sdk
onPaymentIntentNextAction
andSetupIntentNextAction