codegen: add several client.go files #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-go-codegen-5
branch
from
781dd29 to
c511984
Compare
remi-stripe
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Went through the whole PR carefully and it looks correct. Really exciting to see so many files codegen.
My one worry is that we have ids for resources that can be chosen by merchant and have special characters so we need to make sure the id are always properly encoded in URLs when we set them. The PR seems to properly take this into account already so you likely got this but wanted to mention this as a "gotcha" that bit us before.
nadaismail-stripe
added a commit
that referenced
this pull request
Oct 18, 2024
* multi stripe account support (#1260) * Temp commit * Temp checkin to switch tracks * We appear to be ready for config import but need another first-install run. * add import modal * Remove changes for actual config importer to limit scope to just the config manager * Working to improve test coverage * got test coverage up to 83 percent * Initial commit with new API methods * Trivial changes for delete account config * Adding get all account configs api method * Intermediate commit * More changes to bring implementation closer to doc * Update tooling to help find the issue * bad import statements * Init commit of using new composite key * More refactors * Migration to add default field to users * Fix so that we budget for multiple returns, as sf acct id isn't a key anymore * Just the migration script * init commit custom field * Rename Stripe_Account_ID__C.field-meta.xml to Stripe_Account_ID__c.field-meta.xml * Changing label and adding to Order information * Changing text field to more complex structure, not showing up in the UI * Reworking a bit, testing out deploys * Fixing feedback * [Multi Stripe Account] Modifying order poller (#1251) * Adding a simple statement to the soql query * Adding constant and using prefixed stripe field * Update stripe_callback_handler to handle adding stripe accounts, and add provisional v2 connection statuses endpoint * additional pieces needed for other updates * Remove magic strings * Added livemode to response key for status endpoint * got initial connection loop working w/ minor bug to fix later * Adding livemode fields to permission set, modifying order poller, adding constants * Made things work, minimally * Completed essential work for multi-stripe account support * Improved test coverage: Org Wide Coverage 84% * Account poller only polls the default user * Fix missed debug enabling * Add description for stripe id * Added description to stripe account field on order. * Button up multi-stripe account support * Couple tweaks * Added some nice git ignores * Added more instructions to local dev testing * bug bash fixes (#1265) * bug bash fixes * Added comments and soft delete instead of hard deleting users * More pr feedback * UI changes from bug bash * Fix a bug rish was encountering * Removed refs to connection status * Added a comment * Nada pr feedback * Removing bad test --------- Co-authored-by: Keshav Chakrapani <[email protected]> Co-authored-by: keshavc-stripe <[email protected]> Co-authored-by: Nada Ismail <[email protected]> * Fixing the multi stripe account bug * Correcting pr feedback * Adding new script to populate stripe account objects * Fix merge conflicts and remove create stripe account script * Delete dead ruby code * Removing comments from order_poller * Change some of the UI * Refactor stripe callback handler * Rename * Remove doubled lined * Add back state * Fix type errors * Fix livemode error * Fix errors * Add comment * Add error * Fixing reauth bug * typecheck * Update livemode * Set livemode on state * Convert to string * Set livemode * Revert v2 error * Revert or false * Fixing bugs with refactor * Changing comments to be more accurate --------- Co-authored-by: jmather-c <[email protected]> Co-authored-by: Nada Ismail <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts several
client.gofiles to the codegenned format. This should be a complete noop. Most of the diff is changing variable names, arbitrary comment content, and some whitespace/ordering changes.