Multiple API Changes #1241
Merged
Multiple API Changes #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
commented
Jan 14, 2021
remi-stripe
reviewed
Jan 15, 2021
checkout_session.go
Outdated
| type CheckoutSessionCustomerDetails struct { | ||
| Email string `json:"email"` | ||
| TaxExempt CheckoutSessionCustomerDetailsTaxExempt `json:"tax_exempt"` | ||
| TaxIDs []CheckoutSessionCustomerDetailsTaxIDs `json:"tax_ids"` |
There was a problem hiding this comment.
This should be []*CheckoutSessionCustomerDetailsTaxIDs right?
There was a problem hiding this comment.
Good catch!
remi-stripe
reviewed
Jan 15, 2021
issuing_transaction.go
Outdated
| Cardholder *string `form:"cardholder"` | ||
| Created *int64 `form:"created"` | ||
| CreatedRange *RangeQueryParams `form:"created"` | ||
| Type *IssuingTransactionListType `form:"type"` |
There was a problem hiding this comment.
We don't use enums in params, this should be *string instead and we don't need the type. Also if we used the type we would use IssuingTransactionType instead
There was a problem hiding this comment.
Woot! Great to know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
Contains changes corresponding to openapi releases v11 and v12.
Changelog
dynamic_tax_ratesonCheckoutSessionParams.line_itemscustomer_detailsonCheckoutSessiontypeonIssuingTransactionListParamscountryandstateonTaxRateParamsandTaxRate