Add support for passing Bank for P24 on PaymentIntent or PaymentMethod
#1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Oct 23, 2020
| @@ -329,6 +330,7 @@ type PaymentMethodOXXO struct { | |||
|
|
|||
| // PaymentMethodP24 represents the P24 properties. | |||
| type PaymentMethodP24 struct { | |||
| Bank string `json:"bank"` | |||
There was a problem hiding this comment.
Technically bank is an enum so it should have a list of constants but we haven't done that for other bank properties on PaymentMethod yet so I want to stay consistent (easier for code examples and such) and we can fix with codegen later (or manually if needed).
richardm-stripe
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
cc @stripe/api-libraries