Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sepa_debit for bancontact, ideal, sofort #1199

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Support sepa_debit for bancontact, ideal, sofort #1199

merged 3 commits into from
Oct 9, 2020

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Oct 6, 2020 •
edited
Loading

  • Add support for GeneratedSepaDebit and GeneratedSepaDebitMandate to ChargePaymentMethodDetailsBancontract, ChargePaymentMethodDetailsSofort, and ChargePaymentMethodDetailsIdeal
  • Add support for GeneratedFrom to PaymentMethodSepaDebit
  • Add support for Bancontact, Ideal and Sofort to SetupAttemptPaymentMethodDetails

cjavilla-stripe
cjavilla-stripe reviewed Oct 6, 2020
View reviewed changes
paymentmethod.go Outdated
Country string `json:"country"`
Fingerprint string `json:"fingerprint"`
Last4 string `json:"last4"`
GeneratedFrom PaymentMethodSepaDebitGeneratedFrom `json:"generated_from"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this one also be a pointer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup good catch.

@richardm-stripe
Copy link
Contributor Author

ptal @cjavilla-stripe

cjavilla-stripe
cjavilla-stripe approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardm-stripe richardm-stripe merged commit edccda6 into master Oct 9, 2020
@richardm-stripe richardm-stripe deleted the richardm-ideal-sepa branch October 9, 2020 01:59
nadaismail-stripe added a commit that referenced this pull request Oct 18, 2024
@nadaismail-stripe
Duplicate Invoice Issue pt3: Wipe out existing phase add_invoice_items (
89c40d0 
#1199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjavilla-stripe cjavilla-stripe cjavilla-stripe approved these changes

Assignees

@richardm-stripe richardm-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardm-stripe @cjavilla-stripe