Add support for RefreshURL and ReturnURL on AccountLink
#1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
changed the title
RefreshURL and ReturnURL on AccountLinkRefreshURL and ReturnURL on AccountLink
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
…e subscription (#1124) * Add evergreen as a subscription type constant * Utilize original create salesforce order for evergreen * Edit comment and fix up implementation of create evergreen order * Created evergreen order test file with test skeleton * Added test for if end date is nil * Accessed quote obejct from order and wrote more tests * Fixed rubocop errors * Added todo for getting quote, requires further investigation * Add function to check subscription type of an order * Add evergreen constant and add check in order * Write test to simulate translating evergreen order * Raise user error when evergreen encountered and test * Create test to simulate evergreen order translate * Undo changes from wrong task * Create test to simulate evergreen order translate without throwing error * Rubocop fix * Rubocop again * Remove lock file changes * remove spaces * Add some logic for creating subscription * Subscriptions can be created, fixed payment missing * Added days until due for invoice based on sf order * Update sf order with subscription id * Added assertions for translated stripe subscription * Add time test to ensure invoices get created each pay period * Add comments for another test * Repond to PR comments * Add test for different pay period length * Tested longer pay period test * Remove subscription from user field mappings * Add Jira for sanitize stripe subscription * Remove redundant email * Lint and remove dump * Remove changes to lock file * Started test for subscription term not 1 * Changed error message to not yet supported * Changed method of checking whether order evergreen * Added test for user error when order has both evergreen and renewable * Add jira for modifying add_product_to_cpq_quote function * Linted * Remove ruby from lock file * Move create evergreen sf order function back * Add test and check for whether evergreen order subscription term is 1 * Lint * Add two products to cpq quote * Wrote multi order item translate test * Improved user field defaults email creation * Bye bye ruby * Create random email in field defaults instead of mapping * Update Gemfile.lock * Lint * Lint * Update Gemfile.lock * Removed get quote helpful function * Gemfile * Remove redundant fields from subscription * Put subscription code back in migrate pre integration order * Remove test that throws error on evergreen orders * Catch renewable/evergreen salesforce products * Write order creation experiment function in test * Tests pass w this version * Removed redundant code for create subscription * Lint * Update Gemfile.lock * Remove experimentation function from test * Update Gemfile.lock * User email changes * Implemented mapper for translate * Add user field defaults to evergreen tests * Remove Renewable/Evergreen code * Edit * Update Gemfile.lock * Lint * Add evergreen subscription term constant * Add more asserts in basic evergreen order translate and metadata * Remove invoice test * Fixed test * Update Gemfile.lock * Fix test * Lint * Use constant * Use interface in new test * Fix the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @cjavilla-stripe
cc @stripe/api-libraries