Add Metadata and Object on Topup
#1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,8 +49,13 @@ type Topup struct { | |||
| FailureMessage string `json:"failure_message"` | |||
| ID string `json:"id"` | |||
| Livemode bool `json:"livemode"` | |||
| Metadata map[string]string `json:"metadata"` | |||
| Object string `json:"object"` | |||
There was a problem hiding this comment.
I think this one is an enum with just one value topup for now, right? Do we want to add that one value as TopupObject or something?
There was a problem hiding this comment.
We've never done this so no. It's really just a string and I've added it manually to resources when I catch it.
nadaismail-stripe
added a commit
that referenced
this pull request
Oct 18, 2024
* init# * Add Stripe Revenue Contract Id field * fixes and pr comments * added tests * fixes * PR Comments addressed --------- Co-authored-by: Nada Ismail <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1107
r? @cjavilla-stripe
cc @stripe/api-libraries