Add support for the BillingPortal namespace and the Session API and resource
#1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-portal
branch
from
b5856b8 to
49d3c87
Compare
remi-stripe
changed the title
BillingPortal namespace and the Session API and resourceBillingPortal namespace and the Session API and resource
remi-stripe
force-pushed
the
remi-add-portal
branch
from
49d3c87 to
db25b66
Compare
|
I'm hitting a weird error locally I don't understand what is causing those errors at the moment and whether it's related to the change with module or the fact that this is the first namespace with 2 words. Running |
billingportal/session/client.go
Outdated
| import ( | ||
| "net/http" | ||
|
|
||
| stripe "github.com/stripe/stripe-go" |
There was a problem hiding this comment.
Try adding v71 to the end of this like:
stripe "github.com/stripe/stripe-go/v71"Unfortunately this is needed for all stripe-go require paths now.
billingportal/session/client_test.go
Outdated
| "testing" | ||
|
|
||
| assert "github.com/stretchr/testify/require" | ||
| stripe "github.com/stripe/stripe-go" |
There was a problem hiding this comment.
And same with this one: v71 at the end.
|
@remi-stripe I think it's just a minor problem with the format of your ptal @remi-stripe |
remi-stripe
force-pushed
the
remi-add-portal
branch
from
db25b66 to
bd7c983
Compare
|
Ah gotcha, it's the bad luck of having starting the PR before the major was merged. Okay fixed all the issues, PTAL @brandur-stripe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries
cc @alexander-stripe