Add new values for TaxIDType and fix TaxIDTypeCHVAT
#1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
changed the title
TaxIDType and fix TaxIDTypeCHVAT
ob-stripe
approved these changes
Jan 23, 2020
nadaismail-stripe
added a commit
that referenced
this pull request
Oct 18, 2024
* added config hash to setup * resolving merge conflicts and adding test case * updates based on pr comments * fix for failed test case * removed generic toast throwing and updates success error code check based on PR comments * update for failing test classes * fix for failing test * Some nit fixes * Nit changes * Revert small change * Fix syncing the config hash between saves * potentially fix bug during setup phase * missed merge detail * fixed bug with data mapping losing values on back from sync preferences * Trying to reduce some of the ambiguity in the code * Remove a js error in the console * fixed bad ref * more bugs * Pushing this change to see total diff and figure out what else to revert * Reverting a few more changes for clarity --------- Co-authored-by: arnoldezeolisa <[email protected]> Co-authored-by: Nada Ismail <[email protected]> Co-authored-by: Jacob Mather <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
cc @api-libraries