Add support for CreditNoteLineItem
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-wip-credit-note-line
branch
from
271fa5f to
9de0209
Compare
remi-stripe
changed the title
CreditNoteLineItem
ob-stripe
approved these changes
Jan 14, 2020
| TaxRates []*TaxRate `json:"tax_rates"` | ||
| Type CreditNoteLineItemType `json:"type"` | ||
| UnitAmount int64 `json:"unit_amount"` | ||
| UnitAmountDecimal float64 `json:"unit_amount_decimal,string"` |
There was a problem hiding this comment.
not familiar with this string thing at the end so pointing it out. guessing that's how we specify the type of the json field and that'll be converted to float64.
There was a problem hiding this comment.
Yes, that's mostly cargo culted from other resources
creditnote.go
Outdated
| Amount *int64 `form:"amount"` | ||
| CreditAmount *int64 `form:"credit_amount"` | ||
| Invoice *string `form:"invoice"` | ||
| Memo *string `form:"memo"` |
There was a problem hiding this comment.
Should this one have Lines too?
remi-stripe
force-pushed
the
remi-wip-credit-note-line
branch
from
9de0209 to
56cbcb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries