Adds PendingUpdate to Subscription #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjavilla-stripe
force-pushed
the
cjavilla/add-pending-update
branch
from
b56456e to
9539f6a
Compare
cjavilla-stripe
force-pushed
the
cjavilla/add-pending-update
branch
from
9539f6a to
60fea63
Compare
cjavilla-stripe
force-pushed
the
cjavilla/add-pending-update
branch
from
60fea63 to
1ff06ac
Compare
remi-stripe
requested changes
Jan 12, 2020
| @@ -119,6 +119,7 @@ type InvoiceParams struct { | |||
| SubscriptionItems []*SubscriptionItemsParams `form:"subscription_items"` | |||
| SubscriptionPlan *string `form:"subscription_plan"` | |||
| SubscriptionProrate *bool `form:"subscription_prorate"` | |||
| SubscriptionProrationBehavior *string `form:"subscription_proration_behavior"` | |||
There was a problem hiding this comment.
You're missing a list of constants for all those values. In go, we define them even if it's just used as a parameter and we pass *string
There was a problem hiding this comment.
Thanks, I couldn't remember that rule.
cjavilla-stripe
changed the title
|
Added ptal @remi-stripe |
remi-stripe
requested changes
Jan 15, 2020
|
Hmm. Maybe I'm missing something. I thought the upcoming invoice params were controlled by InvoiceParams? Did I miss it somewhere else? |
Ah my bad I always forget that we mix them. All good then. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think I should re-use the existing SubscriptionItem for subscription_items like this? or create a whole new
SubscriptionPendingUpdateSubscriptionItemetc.r? @remi-stripe
cc @stripe/api-libraries