Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AU BECS Debit to PaymentMethod #1002

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

shengwei-stripe
Copy link
Contributor

@remi-stripe @ob-stripe
Add AU BECS Debit PaymentMethod Support

cc @stripe/api-libraries

@remi-stripe remi-stripe self-assigned this Dec 6, 2019
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as dotnet, you're missing the mandate changes per https://github.com/stripe/stripe-java/pull/913/files

Also you're missing the constant for the new type https://github.com/stripe/stripe-go/blob/master/paymentmethod.go#L18

@shengwei-stripe shengwei-stripe removed their assignment Dec 9, 2019
@shengwei-stripe
Copy link
Contributor Author

@remi-stripe Thanks for the review. Done modifications

paymentmethod.go Outdated Show resolved Hide resolved
Code review: Add AUBECSDebit to Mandate

Add PaymentMethod constant definitions

Codereview: typo error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants