Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set Customer.CardParams.Token when creating a customer #4

Closed
joeshaw opened this issue Aug 12, 2014 · 1 comment
Closed

Cannot set Customer.CardParams.Token when creating a customer #4

joeshaw opened this issue Aug 12, 2014 · 1 comment

Comments

@joeshaw
Copy link

joeshaw commented Aug 12, 2014

Lost a bit of time to this: rather than setting Customer.Token to set the token for a card I was creating a CardParams value and setting its Token field and scratching my head about why it doesn't work. The CustomerClient.Create method doesn't look for this, but maybe it should?
@joeshaw joeshaw changed the title Cannot set Customer.CardParams.Token when creating a user Cannot set Customer.CardParams.Token when creating a customer Aug 12, 2014
cosn added a commit that referenced this issue Sep 2, 2014
@cosn
Make card token passing more intuitive
0c6a077 
You can pass it via *Params.Token or via *Params.CardParams.Token to
avoid confusion

Fixes issue #4
@cosn cosn closed this as completed Sep 2, 2014
@joeshaw
Copy link
Author

joeshaw commented Sep 3, 2014

thanks!

siddarth added a commit that referenced this issue Sep 14, 2015
@siddarth
Merge pull request #4 from stripe-internal/sidd-product-update
01e19f5 
ProductUpdate support.
nadaismail-stripe pushed a commit that referenced this issue Oct 18, 2024
@mbianco-stripe
Refactor #4: pricing refactor (#611)
e4b4b28 
* Adding workplan

* Extracting out price comparison helper

* PUlling transform_salesforce_billing_type_to_usage_type to functional helpers

* Extract out tiered params sanitization

* Eliminate sf_cpq_term_interval helper

* Extract out custom price detection logic

* Test for price helpers

* Fixing mapper tests

Tests removed are already covered in another test

* Bump sfdx version to maybe fix ci issue

* Fix typing error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeshaw @cosn