add a comment about assigning RawJSON

stripe · Jul 27, 2020 · a40214c · a40214c
1 parent 9fec249
commit a40214c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/ephemeralkey.go b/ephemeralkey.go
@@ -46,6 +46,9 @@ func (e *EphemeralKey) UnmarshalJSON(data []byte) error {
 		*e = EphemeralKey(ee)
 	}
 
+	// Go does guarantee the longevity of `data`, so copy when assigning `RawJSON`
+	// See https://golang.org/pkg/encoding/json/#Unmarshaler
+	// and https://github.com/stripe/stripe-go/pull/1142
 	e.RawJSON = append(e.RawJSON[:0], data...)
 
 	return nil