Fix edge case panic in ParseID (#1249)

stripe · Feb 17, 2021 · 417a16e · 417a16e
1 parent 9061e06
commit 417a16e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/stripe.go b/stripe.go
@@ -977,6 +977,11 @@ func ParseID(data []byte) (string, bool) {
 		return "", false
 	}
 
+	// Edge case that should never happen; found via fuzzing
+	if s == "\"" {
+		return "", false
+	}
+
 	return s[1 : len(s)-1], true
 }
 

diff --git a/stripe_test.go b/stripe_test.go
@@ -777,6 +777,13 @@ func TestParseID(t *testing.T) {
 		assert.Equal(t, "", id)
 		assert.False(t, ok)
 	}
+
+	// Edge case that should never happen; found via fuzzing
+	{
+		id, ok := ParseID([]byte(`"`))
+		assert.Equal(t, "", id)
+		assert.False(t, ok)
+	}
 }
 
 // TestMultipleAPICalls will fail the test run if a race condition is thrown while running multiple NewRequest calls.