Fix remaining params not passed as booleans

stripe · Jun 6, 2018 · 165546b · 165546b
1 parent 00d32a1
commit 165546b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/plan.go b/plan.go
@@ -107,8 +107,8 @@ type PlanTransformUsage struct {
 
 // PlanTransformUsageParams represents the bucket billing configuration.
 type PlanTransformUsageParams struct {
-	DivideBy int64  `form:"bucket_size"`
-	Round    string `form:"round"`
+	DivideBy *int64  `form:"bucket_size"`
+	Round    *string `form:"round"`
 }
 
 // PlanTierParams configures tiered pricing

diff --git a/plan_test.go b/plan_test.go
@@ -67,8 +67,8 @@ func TestPlanParams_AppendTo(t *testing.T) {
 		{"tiers[0][up_to]", &PlanParams{Tiers: tiers}, strconv.FormatUint(321, 10)},
 		{"tiers[1][amount]", &PlanParams{Tiers: tiers}, strconv.FormatUint(123, 10)},
 		{"tiers[1][up_to]", &PlanParams{Tiers: tiers}, "inf"},
-		{"transform_usage[bucket_size]", &PlanParams{TransformUsage: &PlanTransformUsageParams{DivideBy: 123, Round: "round_up"}}, strconv.FormatUint(123, 10)},
-		{"transform_usage[round]", &PlanParams{TransformUsage: &PlanTransformUsageParams{DivideBy: 123, Round: "round_up"}}, "round_up"},
+		{"transform_usage[bucket_size]", &PlanParams{TransformUsage: &PlanTransformUsageParams{DivideBy: Int64(123), Round: String("round_up")}}, strconv.FormatUint(123, 10)},
+		{"transform_usage[round]", &PlanParams{TransformUsage: &PlanTransformUsageParams{DivideBy: Int64(123), Round: String("round_up")}}, "round_up"},
 		{"trial_period_days", &PlanParams{TrialPeriodDays: Int64(123)}, strconv.FormatUint(123, 10)},
 		{"usage_type", &PlanParams{UsageType: String("metered")}, "metered"},
 	}

diff --git a/product.go b/product.go
@@ -91,7 +91,7 @@ type ProductListParams struct {
 	Active     *bool    `form:"active"`
 	IDs        []string `form:"ids"`
 	Shippable  *bool    `form:"shippable"`
-	URL        string   `form:"url"`
+	URL        *string  `form:"url"`
 }
 
 // UnmarshalJSON handles deserialization of a Product.

diff --git a/sub.go b/sub.go
@@ -66,11 +66,11 @@ func (p *SubscriptionParams) AppendTo(body *form.Values, keyParts []string) {
 // For more details see https://stripe.com/docs/api#create_subscription and https://stripe.com/docs/api#update_subscription.
 type SubscriptionItemsParams struct {
 	Params     `form:"*"`
-	ClearUsage bool   `form:"clear_usage"`
-	Deleted    bool   `form:"deleted"`
-	ID         string `form:"id"`
-	Plan       string `form:"plan"`
-	Quantity   *int64 `form:"quantity"`
+	ClearUsage *bool   `form:"clear_usage"`
+	Deleted    *bool   `form:"deleted"`
+	ID         *string `form:"id"`
+	Plan       *string `form:"plan"`
+	Quantity   *int64  `form:"quantity"`
 }
 
 // SubscriptionListParams is the set of parameters that can be used when listing active subscriptions.

diff --git a/sub/client_test.go b/sub/client_test.go
@@ -50,7 +50,7 @@ func TestSubscriptionNew_WithItems(t *testing.T) {
 		Customer: stripe.String("cus_123"),
 		Items: []*stripe.SubscriptionItemsParams{
 			{
-				Plan:     "gold",
+				Plan:     stripe.String("gold"),
 				Quantity: stripe.Int64(0),
 			},
 		},