Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for radar.early_warning_fraud resource #1626

Merged
merged 1 commit into from
May 24, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Add support for radar.early_warning_fraud resource

@ob-stripe
Copy link
Contributor Author

Hrm, so builds are failing because the new OpenAPI spec has API version 2019-05-16 but the library is still pinned to 2019-03-14 and the CI pipeline runs stripe-mock with the -check option.

I can confirm that tests pass locally:

$ dotnet test src/StripeTests
Build started, please wait...
Build completed.

Test run for /Users/ob/workspace/dotnet/stripe-dotnet/src/StripeTests/bin/Debug/netcoreapp1.1/StripeTests.dll(.NETCoreApp,Version=v1.1)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 733. Passed: 733. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 9.7129 Seconds
Test run for /Users/ob/workspace/dotnet/stripe-dotnet/src/StripeTests/bin/Debug/netcoreapp2.1/StripeTests.dll(.NETCoreApp,Version=v2.1)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 734. Passed: 734. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 7.1861 Seconds
Test run for /Users/ob/workspace/dotnet/stripe-dotnet/src/StripeTests/bin/Debug/net452/StripeTests.dll(.NETFramework,Version=v4.5.2)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 730. Passed: 730. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 6.3236 Seconds

Given the limited scope of the new API version (https://stripe.com/docs/upgrades#2019-05-16), I think it's safe to merge this and release a new major version separately.

@brandur-stripe
Copy link
Contributor

Given the limited scope of the new API version (https://stripe.com/docs/upgrades#2019-05-16), I think it's safe to merge this and release a new major version separately.

Yeah, that sounds good to me. Let's make sure to get the new release coordinated relatively soon, but it looks like you've taken care of that already.

LGTM.

@ob-stripe
Copy link
Contributor Author

Thanks!

@ob-stripe ob-stripe merged commit ac95d30 into master May 24, 2019
@ob-stripe ob-stripe deleted the ob-early-fraud-warning branch May 24, 2019 17:49
@ob-stripe
Copy link
Contributor Author

Released as 25.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants