Add support for spending_limits on Issuing Card and Cardholder
#1576
Conversation
|
cc @zacht-stripe to triple check the changes and make sure I did not miss anything |
| [JsonProperty("spending_limits")] | ||
| public SpendingLimits SpendingLimits { get; set; } | ||
|
|
||
| [Obsolete("This is now unsupported")] |
There was a problem hiding this comment.
Can we improve this message? This isn't super helpful 😂
There was a problem hiding this comment.
Hmmm I was not sure what to put. Like there's no replacement or anything. It's just removed as a property.
There was a problem hiding this comment.
@ob-stripe What do you think of this one?
There was a problem hiding this comment.
Did you mean to change it? The message hasn't changed.
There was a problem hiding this comment.
I am asking you what I should put. This option is just entirely removed, it's not replaced by anything. So I don't know what to put beyond "please stop using it". Do you have any idea what string would be enough for you?
remi-stripe
force-pushed
the
remi-issuing-authorization-controls
branch
from
6db2869 to
daa24bc
Compare
|
Turns out |
Yes please. |
remi-stripe
force-pushed
the
remi-issuing-authorization-controls
branch
from
daa24bc to
868fb9a
Compare
|
@ob-stripe okay fixed. Can I ask you to re-review carefully? I broke stripe-go so want to make ~sure it's correct :p |
|
Hi @ob-stripe / @remi-stripe |
|
@the800kid Thanks for reaching out! I paused those changes for now as we're changing the shape of the API a little bit so I was waiting for someone to need this before releasing it. Since you need it though, I'll work on finishing those today! |
|
Closing in favour of #1877 |
|
@remi-stripe Thank you for the quick reply and action. I see you have made changes to the models since the original work. Looking forward to being able to use the feature. Thanks again! |
|
@the800kid This was released in 34.4.0! Let me know if you encounter any issues! |
Related to stripe/stripe-go#831
r? @ob-stripe
cc @stripe/api-libraries