Link Cvc & Expiry recollection VM #9882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -23,7 +30,11 @@ internal data class WalletUiState( | |||
| val isExpired = card?.isExpired ?: false | |||
| val requiresCvcRecollection = card?.cvcCheck?.requiresRecollection ?: false | |||
|
|
|||
| val disableButton = isExpired || requiresCvcRecollection | |||
| val isMissingExpiryDateInput = (expiryDateInput.isComplete && cvcInput.isComplete).not() | |||
There was a problem hiding this comment.
The isMissingExpiryDateInput check appears to have an unintended dependency on cvcInput.isComplete. For validating expiry date input, the condition should be simplified to expiryDateInput.isComplete.not() since the CVC completion state is handled separately by isMissingCvcInput.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
expired cards requires both updated expiryDate and cvc
|
Diffuse output: APKDEX |
toluo-stripe
commented
Jan 10, 2025
paymentsheet/src/main/java/com/stripe/android/link/ui/wallet/WalletViewModel.kt
Outdated
Show resolved
Hide resolved
toluo-stripe
force-pushed
the
tolu/link/cvc_expiry_vm
branch
from
69e29e5 to
7026722
Compare
Comment on lines
189
to
197
| is LinkConfirmationResult.Failed -> { | ||
| _uiState.update { | ||
| it.copy(errorMessage = result.message) | ||
| } | ||
| } |
There was a problem hiding this comment.
The isProcessing state should be set to false when handling the error case, otherwise the UI will remain in a loading state after the error occurs. Consider updating the copy() call:
it.copy(
errorMessage = result.message,
isProcessing = false
)Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
toluo-stripe
force-pushed
the
tolu/link/cvc_expiry_vm
branch
from
64aa78d to
76e4129
Compare
Comment on lines
+187
to
+189
| when (result) { | ||
| LinkConfirmationResult.Canceled -> Unit |
There was a problem hiding this comment.
The isProcessing state should be reset when the confirmation is canceled. Consider updating the case to:
LinkConfirmationResult.Canceled -> _uiState.update { it.copy(isProcessing = false) }This maintains consistency with the error handling case and prevents the UI from being stuck in a processing state.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
amk-stripe
reviewed
Jan 14, 2025
payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsElement.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/test/java/com/stripe/android/link/ui/wallet/WalletUiStateTest.kt
Show resolved
Hide resolved
| @Test | ||
| fun `performPaymentConfirmation skips update for non-expired card`() = runTest(dispatcher) { | ||
| val validCard = TestFactory.CONSUMER_PAYMENT_DETAILS_CARD.copy(expiryYear = 2099) | ||
| val linkAccountManager = object : FakeLinkAccountManager() { |
There was a problem hiding this comment.
wdyt of creating a shared FakeLinkAccountManager and re-using it across tests? A lot of these tests seem to be quite long and are creating their own very similar fakes. I think we could simplify + increase code re-use by sharing a fake
Add confirmation block Update unit tests Lint Update WalletViewModelTest.kt Update FakeLinkConfirmationHandler.kt
toluo-stripe
force-pushed
the
tolu/link/cvc_expiry_vm
branch
from
f6dc691 to
b90d319
Compare
Comment on lines
+154
to
+169
| performPaymentDetailsUpdate(selectedPaymentDetails).fold( | ||
| onSuccess = { result -> | ||
| val updatedPaymentDetails = result.paymentDetails.single { | ||
| it.id == selectedPaymentDetails.id | ||
| } | ||
| performPaymentConfirmation(updatedPaymentDetails) | ||
| }, | ||
| onFailure = { error -> | ||
| _uiState.update { | ||
| it.copy( | ||
| alertMessage = error.stripeErrorMessage(), | ||
| isProcessing = false | ||
| ) | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
The onFailure block needs to return early to prevent execution from continuing into payment confirmation. Add return after updating the UI state to ensure the error case fully terminates the flow.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
amk-stripe
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Screenshots (UI not part of this PR)
Screen.Recording.2025-01-09.at.1.50.06.AM.mov
Changelog