-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SavedPaymentMethod accessibility issue #9874
Conversation
Diffuse output:
APK
|
viewWidth: Dp, | ||
isSelected: Boolean, | ||
shouldShowModifyBadge: Boolean, | ||
isEnabled: Boolean, | ||
isClickable: Boolean = isEnabled, | ||
iconRes: Int, | ||
modifier: Modifier = Modifier, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth reverting this change to minimize the diff to only necessary changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint check warns me about "modifier not being the first parameter" when committing. Maybe we could keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the first optional parameter that it's warning about, not that it has to be exactly the first parameter. I think in general it's worth doing a separate PR for these types of things, but I'm not blocking on it if you want to ship it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Will separate this kind of modification next time. Merging now to avoid unnecessary check rerun.
Summary
Modify SavedPaymentMethodTab click group to match the accessibility requirements
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2678
This pull request aims to improve accessibility for VoiceOver users on the payment method selection screen. It ensures that when the "Add" tab is selected, VoiceOver reads out "Button, double tap to select, Add new card," and provides clear identification of saved payment methods by announcing the card name or number when selected. These enhancements will facilitate better navigation and understanding for users relying on screen readers.
Testing
Screenshots
Changelog