Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete useNewUpdateCardScreen feature flag #9842

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

amk-stripe
Copy link
Collaborator

Summary

Delete useNewUpdateCardScreen feature flag

Motivation

The flag is no longer being used.

https://jira.corp.stripe.com/browse/MOBILESDK-2874

Testing

  • Added tests
  • Modified tests
  • Manually verified

@amk-stripe amk-stripe requested review from a team as code owners January 2, 2025 21:18
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │        uncompressed         
          ├───────────┬───────────┬────────┼──────────┬──────────┬───────
 APK      │ old       │ new       │ diff   │ old      │ new      │ diff  
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼───────
      dex │   3.9 MiB │   3.9 MiB │ -132 B │  8.6 MiB │  8.6 MiB │ -84 B 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │  2.2 MiB │  2.2 MiB │   0 B 
 manifest │     5 KiB │     5 KiB │    0 B │ 24.9 KiB │ 24.9 KiB │   0 B 
      res │ 908.4 KiB │ 908.4 KiB │    0 B │  1.4 MiB │  1.4 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │    6 MiB │    6 MiB │   0 B 
    asset │   1.6 MiB │   1.6 MiB │   -1 B │  1.6 MiB │  1.6 MiB │  -1 B 
    other │   1.4 MiB │   1.4 MiB │   -5 B │  1.6 MiB │  1.6 MiB │   0 B 
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼───────
    total │  12.6 MiB │  12.6 MiB │ -138 B │ 21.5 MiB │ 21.5 MiB │ -85 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 40596 │ 40595 │ -1 (+1 -2) 
   types │ 14010 │ 14010 │  0 (+0 -0) 
 classes │ 11684 │ 11684 │  0 (+0 -0) 
 methods │ 59631 │ 59631 │  0 (+0 -0) 
  fields │ 39811 │ 39810 │ -1 (+0 -1) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6208 │ 6208 │  0
APK
    compressed     │   uncompressed    │                               
──────────┬────────┼───────────┬───────┤                               
 size     │ diff   │ size      │ diff  │ path                          
──────────┼────────┼───────────┼───────┼───────────────────────────────
  3.9 MiB │ -132 B │   8.6 MiB │ -84 B │ ∆ classes.dex                 
  1.2 KiB │   -3 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA           
 50.2 KiB │   -2 B │ 118.4 KiB │   0 B │ ∆ META-INF/MANIFEST.MF        
  7.8 KiB │   -1 B │   7.7 KiB │  -1 B │ ∆ assets/dexopt/baseline.prof 
──────────┼────────┼───────────┼───────┼───────────────────────────────
    4 MiB │ -138 B │   8.7 MiB │ -85 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40596 │ 40595 │ -1 (+1 -2) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"6430e07","r8-mode":"full","version":"8.7.14"}
  
  - Enable new update card screen
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"f4a91d4","r8-mode":"full","version":"8.7.14"}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   39811 │ 39810 │ -1 (+0 -1) 
  
  - i5.d c: t

@amk-stripe amk-stripe enabled auto-merge (squash) January 2, 2025 21:31
@amk-stripe amk-stripe merged commit c794da1 into master Jan 3, 2025
16 checks passed
@amk-stripe amk-stripe deleted the remove-update-screen-ff branch January 3, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants