Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LiveData from PaymentSessionViewModel. #7526

Merged

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

We did a conversion to remove all these from the paymentsheet module, but it's not happened yet for payments core. I noticed this recently when working on another task.

Motivation

Unify all of our observables around Flow

Testing

Manually verified, and confirmed existing tests pass.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.6 MiB │   3.6 MiB │  0 B │   7.8 MiB │   7.8 MiB │  0 B 
     arsc │   2.3 MiB │   2.3 MiB │  0 B │   2.3 MiB │   2.3 MiB │  0 B 
 manifest │   5.1 KiB │   5.1 KiB │  0 B │  25.4 KiB │  25.4 KiB │  0 B 
      res │ 905.5 KiB │ 905.5 KiB │  0 B │   1.4 MiB │   1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │     3 MiB │     3 MiB │  0 B │     3 MiB │     3 MiB │  0 B 
    other │ 204.5 KiB │ 204.5 KiB │  0 B │ 460.3 KiB │ 460.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.5 MiB │  12.5 MiB │  0 B │  20.8 MiB │  20.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 38527 │ 38527 │ 0 (+0 -0) 
   types │ 12669 │ 12669 │ 0 (+0 -0) 
 classes │ 10652 │ 10652 │ 0 (+0 -0) 
 methods │ 55476 │ 55476 │ 0 (+0 -0) 
  fields │ 35667 │ 35667 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6936 │ 6936 │  0

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-livedata-PaymentSessionViewModel branch from 5331af5 to 96f8fee Compare October 30, 2023 18:44
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-livedata-PaymentSessionViewModel branch from 96f8fee to ced5ca8 Compare November 12, 2023 19:13
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review November 13, 2023 15:37
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners November 13, 2023 15:37
@jaynewstrom-stripe jaynewstrom-stripe merged commit dd30bf1 into master Nov 13, 2023
10 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/remove-livedata-PaymentSessionViewModel branch November 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants